Update README.md #378
Update README.md #378
Conversation
GitHub Actions Integration updated according to the latest working case.
README.md
Outdated
| - run: gem install pronto pronto-rubocop | ||
| - run: PRONTO_PULL_REQUEST_ID="$(jq --raw-output .number "$GITHUB_EVENT_PATH")" PRONTO_GITHUB_ACCESS_TOKEN="${{ secrets.GITHUB_TOKEN }}" pronto run -f github_status github_pr -c origin/master | ||
| - run: PRONTO_PULL_REQUEST_ID="$(jq --raw-output .number "$GITHUB_EVENT_PATH")" PRONTO_GITHUB_ACCESS_TOKEN="${{ github.token }}" bundle exec pronto run -f github_status github_pr -c origin/${{ github.base_ref }} |
There was a problem hiding this comment.
I also has to add .pull_request.number vs .number not sure if you experienced this as well?
There was a problem hiding this comment.
seems working fine for me :-
There was a problem hiding this comment.
When adding bundle exec the following error occurs Bundler::GemNotFound. I don't believe the Workflow creates a Gemfile, causing this error. Perhaps this should be removed?
There was a problem hiding this comment.
yes, you are right but since I have used with Gemfile and bundler is now part of the lastest ruby.
Running command directly was causing Pronto not found issue. I am thinking to write a wiki for specific integrations where such things can be mentioned.
There was a problem hiding this comment.
Yes, but for this README, to @jaydorsey 's comment below, most people will copy and paste this snippet. In order for bundle exec to work, there should be the steps of bundle install etc before hand. If not, simply removing bundle exec allows for the minimum requirements needed to get this working as an isolated event.
There was a problem hiding this comment.
@smridge updated, please review.
README.md
Outdated
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| - run: | | ||
| git fetch --prune --unshallow |
There was a problem hiding this comment.
What's the benefit of passing in --unshallow? Asking because I usually set my linting pipelines up with a --depth=N (maybe 10 usually?) to reduce the size of the transfer and make the clone faster, because you're only linting a specific commit/snapshot in time
Edit: I know this is just a README example, but was curious if there was a benefit of setting the example, which people are likely to copy/paste from, as this that I'm missing
There was a problem hiding this comment.
@jaydorsey --depth=1 didn't work for me and found --unshallow resolve the issue without much very about depth size. I will create a wiki page and try to specify it over there.
Thanks for your input.
There was a problem hiding this comment.
@jaydorsey updating with
- run: |
git fetch --no-tags --prune --depth=10 origin +refs/heads/*:refs/remotes/origin/*
There was a problem hiding this comment.
Did you mean to tag me in here?
There was a problem hiding this comment.
Did you mean to tag me in here?
Oops! typo 🤯
There was a problem hiding this comment.
@jaydorsey updated, please review.
|
@mknapik can you merge ? |
|
Sure, thanks for your contribution! |
GitHub Actions Integration updated according to the latest working case.