Ruby 3.0 #396
Merged
Ruby 3.0 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ruby 3.0 `rexml` is not installed by default. [It was moved to a gem][1]. Adding the gem as a dependency fixed the specs on ruby 3.0. [1]: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
|
Looks like the Ruby 3.0 build is broken with Travis CI. I guess we should migrate to GitHub Actions? 🤔 |
Yeah this might be a good idea, I don't know if the Ruby 3.0 build can be fixed on Travis. Even if it does the build (queue) times are ridiculous at the moment. |
On focal Ruby 2.7 can not be installed without additional packages. With bionic CI is green from 2.3 up to 3.0.
|
Got it working on TravisCI and submitted a draft PR which runs CI on GitHub actions: #397 |
ashkulz
approved these changes
Jan 30, 2021
|
Thanks for the contribution, @dsander! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ruby 3.0
rexmlis not installed by default. It was moved to agem. Adding the gem as a dependency fixed the specs on ruby 3.0.