Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how formatters are registered, allowing the addition of custom formatter #450

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

emilio2hd
Copy link
Contributor

@emilio2hd emilio2hd commented Oct 22, 2023

Use the same Devise logic to registry the formatters, instead of using a frozen const.

Please check #451 for more context

Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, @emilio2hd! Just a few minor changes and we're good to go.

lib/pronto/formatter/formatter.rb Outdated Show resolved Hide resolved
lib/pronto/formatter/formatter.rb Outdated Show resolved Hide resolved
lib/pronto/formatter/formatter.rb Outdated Show resolved Hide resolved
lib/pronto/formatter/formatter.rb Outdated Show resolved Hide resolved
@ashkulz ashkulz merged commit 755a67f into prontolabs:master Oct 27, 2023
8 of 9 checks passed
@ashkulz
Copy link
Member

ashkulz commented Oct 27, 2023

Thanks for the contribution, @emilio2hd!

@emilio2hd
Copy link
Contributor Author

Thank for the guidance and accepting the contribution! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants