Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluralizer is wrong on words ending with "o" #4

Closed
willdurand opened this issue Aug 4, 2011 · 2 comments
Closed

pluralizer is wrong on words ending with "o" #4

willdurand opened this issue Aug 4, 2011 · 2 comments

Comments

@willdurand
Copy link
Contributor

currently words ending with "o" are pluralized in "oes". I think it's not default plural for too much English words.
Examples: photo, video, typo...

Indeed, I tried

egrep 'o$' /usr/share/dict/american-english

and I hardly found words for which plural ends with "oes".


Imported from: http://www.propelorm.org/ticket/1486

@fzaninotto
Copy link
Member

note that Pluralizers are a buildtime component, which is also sometimes useful at runtime...

@willdurand
Copy link
Contributor Author

@fzaninotto Yep, the same plain old problem of the two sub-projects...

willdurand added a commit that referenced this issue Sep 9, 2013
MDrollette pushed a commit to OrderMyGear/Propel that referenced this issue Jun 13, 2019
DanielFortuyn pushed a commit to DanielFortuyn/Propel that referenced this issue Feb 10, 2023
* Correct deprecated methods in PHP7.4 (propelorm#1079)

* runtime/lib/query/Join.php
  implode() was used against the definition (wrong PHP documentation

* runtime/lib/query/ModelCriteria.php
  count() was used on non-countable variable (non-array)

* 7.4 and phpunit9 changes. Tests are passing

* Compatibility changes

* Added docker setup

* updated travis

* added correct path

* 7.4 final travis setup

* propelorm#1086: Code review suggestions applying

* remove dependency on docker mysql

* remove 5.6 and 7.2 from test matrix; add 8.0 and 8.1

* Upgraded PHP version and removed some deprecations

* Migrated phpunit.xml.dist

* Switched to PHP8.0 in Dockerfile

* Removed usage of ReflectionClass->getClass in favor of ReflectionClass->getType

* Changed order of arguments in ModelCriteriaTest.php and ModelCriteriaWithNamespaceTest.php

* Fixed signatures of PropelOnDemandCollection::asort and PropelOnDemandCollection::ksort

* Removed require_once from all the classes because we have autoloading via composer

* Rector automated upgrade to PHP8

* Fixed invalid handling of resource type for binded value in DebugPDOStatement.php

* Fixed invalid way of checking if method exists in delegated class via is_callable. Switched to method_exists

* Replaced order of params because of failed tests

* [STYLE]: Added simplified usage because of version support dropping

* Fix use of abs() with string on PHP8.0

Can happen when using Yaml's multiline syntax

* specify minimum version of phing for php8

* drop php 7.3 from test matrix

* update to ubuntu-20.04

* fork propel/propel1 for versions >=1.8

Co-authored-by: Michal Drozd <[email protected]>
Co-authored-by: Luke Adamczewski <[email protected]>
Co-authored-by: Łukasz Adamczewski <[email protected]>
Co-authored-by: Jeffrey Wong <[email protected]>
Co-authored-by: Luke Adamczewski <[email protected]>
Co-authored-by: Paulo Magalhaes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants