Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added template for phpstan #1859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmytro-dymarchuk
Copy link
Contributor

Inspired by #1657

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #1859 (9bd9611) into master (0cfea4e) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff            @@
##             master    #1859   +/-   ##
=========================================
  Coverage     87.58%   87.58%           
+ Complexity     7791     7790    -1     
=========================================
  Files           227      227           
  Lines         21105    21109    +4     
=========================================
+ Hits          18485    18489    +4     
  Misses         2620     2620           
Flag Coverage Δ
5-max 87.58% <71.42%> (+<0.01%) ⬆️
7.4 87.58% <71.42%> (+<0.01%) ⬆️
agnostic 66.91% <42.85%> (+0.01%) ⬆️
mysql 68.84% <42.85%> (-0.02%) ⬇️
pgsql 68.85% <42.85%> (-0.02%) ⬇️
sqlite 66.68% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Generator/Builder/Om/ObjectBuilder.php 94.16% <ø> (ø)
...c/Propel/Runtime/ActiveQuery/BaseModelCriteria.php 83.33% <ø> (ø)
src/Propel/Runtime/ActiveQuery/ModelCriteria.php 96.66% <ø> (ø)
src/Propel/Runtime/Collection/ArrayCollection.php 90.00% <ø> (ø)
...c/Propel/Runtime/Collection/CollectionIterator.php 52.50% <ø> (ø)
src/Propel/Runtime/Collection/ObjectCollection.php 96.95% <ø> (ø)
...Runtime/Collection/ObjectCombinationCollection.php 72.72% <ø> (ø)
...c/Propel/Runtime/Collection/OnDemandCollection.php 63.15% <ø> (ø)
src/Propel/Runtime/Collection/OnDemandIterator.php 93.54% <ø> (ø)
src/Propel/Runtime/Formatter/AbstractFormatter.php 76.19% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfea4e...9bd9611. Read the comment docs.

@dmytro-dymarchuk dmytro-dymarchuk force-pushed the bugfix/added-template-annotations-to-collection-criteria branch from cd0f10e to 2ecd9ee Compare April 6, 2022 21:39
@dmytro-dymarchuk dmytro-dymarchuk force-pushed the bugfix/added-template-annotations-to-collection-criteria branch from 2ecd9ee to 8137e3a Compare April 6, 2022 21:44
@dmytro-dymarchuk dmytro-dymarchuk force-pushed the bugfix/added-template-annotations-to-collection-criteria branch from 9bd9611 to 38af019 Compare April 7, 2022 12:50
@dereuromark
Copy link
Contributor

30 errors found
psalm aint too happy yet

@dereuromark
Copy link
Contributor

Can we extract some of the cleanups from this already maybe?

@dereuromark
Copy link
Contributor

@dmytro-dymarchuk Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants