Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use-dmypy option to MypyTool #611

Merged
merged 1 commit into from
May 7, 2023

Conversation

lukaspiatkowski
Copy link
Contributor

Description

Mypy provides an API to use their daemon to speed up type checking. With this change, the use-dmypy configuration can be used to toggle usage of that API by prospector.

Motivation and Context

Mypy tends to be very slow on large repositories, using Mypy daemon makes it much faster.

How Has This Been Tested?

I've run prospector --with-tool mypy -t mypy <file> on a <file> in a large repository with and without use-dmypy option. The difference was 0.57s vs 17.44s in favor of using dmypy.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@carlio
Copy link
Contributor

carlio commented May 7, 2023

Also LGTM, so I shall merge this too.

Note that as a result of #612 the documentation is not building on readthedocs, I will have to look into that before making a release with these in.

@carlio carlio merged commit 02b84b3 into prospector-dev:master May 7, 2023
@carlio carlio mentioned this pull request May 7, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants