Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve tests readability #161

Merged
merged 2 commits into from
Jul 9, 2024
Merged

ci: improve tests readability #161

merged 2 commits into from
Jul 9, 2024

Conversation

CandiedCode
Copy link
Contributor

@CandiedCode CandiedCode commented Jul 9, 2024

Change Description

The intent was to understand why faker pr was failing, by

  1. adding colorized output to improve readability for pytests in the github actions log.
  2. investigate why tests are failing in the two dependabot pr's.

#159 was failing due to a huggingface timeout
https://github.com/protectai/llm-guard/actions/runs/9841118912/job/27166982978 is failing due to some strange npm issue maybe related to the github cache?

Either way both dependencies are passing in this PR.

Before --color support
Screenshot 2024-07-08 at 7 57 06 PM

After --color support
Screenshot 2024-07-08 at 7 55 45 PM

Issue reference

This PR fixes issue #XX

Checklist

  • I have reviewed the contribution guidelines
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@CandiedCode CandiedCode changed the title Tests ci: improve tests readability Jul 9, 2024
@CandiedCode CandiedCode marked this pull request as ready for review July 9, 2024 01:02
@CandiedCode CandiedCode requested a review from asofter as a code owner July 9, 2024 01:02
@asofter asofter merged commit 2fa5d14 into protectai:main Jul 9, 2024
19 of 33 checks passed
@asofter
Copy link
Collaborator

asofter commented Jul 9, 2024

Thank you @CandiedCode !

@CandiedCode CandiedCode deleted the tests branch July 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants