adding rtl function for the sheet #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function write_ws_xml_sheetviews(ws, opts, idx, wb) { | ||
| var sview = ({workbookViewId:"0"}); | ||
| // $FlowIgnore | ||
| if((((wb||{}).Workbook||{}).Views||[])[0]) sview.rightToLeft = wb.Workbook.Views[0].RTL ? "1" : "0"; |
There was a problem hiding this comment.
One-liners are the style of this project: but that is wrong and dangerous and hard to read. I am not a project owner, but this is something to consider.
There was a problem hiding this comment.
Can you explain in your pull (now 2 years stale) what this does, exactly?
| @@ -7925,7 +7931,8 @@ function write_ws_xml(idx, opts, wb) { | |||
| tabSelected: opts.tabSelected === undefined ? '0' : opts.tabSelected, // see issue #26, need to set WorkbookViews if this is set | |||
| workbookViewId: opts.workbookViewId === undefined ? '0' : opts.workbookViewId | |||
| }); | |||
| o[o.length] = writextag('sheetViews', sheetView); | |||
| // o[o.length] = writextag('sheetViews', sheetView); | |||
| o[o.length] = write_ws_xml_sheetviews(ws, opts, idx, wb); | |||
|
I think this is a great idea. This project may just be too old to really have further development. Lack of tests being the major factor. I would love to fork this myself, and have fixed several local bugs that will never make it upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.