Add support for longs: BigInt in toObject
#1908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
commented
Jul 6, 2023
cli/package-lock.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| }, | |||
| "..": { | |||
| "name": "protobufjs", | |||
| "version": "7.1.2", | |||
| "version": "7.2.4", | |||
There was a problem hiding this comment.
This change appeared when I ran npm run build. Seems harmless and correct(?)
|
too soon! |
|
Hi @alexander-fenster, any chance you would be able to take a look and provide some feedback on this? Thank you 🙏 |
jtbandes
force-pushed
the
jacob/toobject-bigint
branch
from
9e56e60
to
8f7ec32
Compare
|
FYI I've published this fork on npm as |
|
Still very interested in seeing this get merged |
|
I've published a new version 0.0.1-toobject-bigint.2 based on v7.3.0. |
|
@alexander-fenster @mkruskal-google Sorry for direct ping, I'm sure you are busy, but is there any chance yall would be able to provide some guidance/insight on when you might expect to have time to review PRs like this one (and many others in the backlog)? Thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
toObject({ longs: BigInt }), which converts longs to native BigInts.This is structured as opt-in so that hopefully it can be shipped in a minor update without having to wait for a 8.x release.
I tested performance of conversion using both
DataView.getBig(U)Int64and plain bitwise arithmetic: https://jsbench.me/1lljqc4kd7/2 The DataView version was faster, but since getBig(U)Int64 is a relatively more recent addition, I provided a fallback for environments that don't support it.See also:
Motivation:
Currently we are maintaining a patch for protobufjs in foxglove/studio. In order to publish some of these packages to NPM, we replace the patch with something that can actually be shipped in
dependencies.