This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
run go mod tidy (and set Go 1.15) and gofmt -s in copy workflow #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2021
Stebalien
approved these changes
Apr 1, 2021
|
Nice! We could also consider running |
mvdan
approved these changes
Apr 1, 2021
| if ! git diff --quiet; then | ||
| git add . | ||
| git commit -m "run gofmt -s" | ||
| echo "NEEDS_UPDATE=1" >> $GITHUB_ENV |
There was a problem hiding this comment.
I kinda wonder if you could later just ask git "are there any commits ahead of the upstream branch?" instead of using NEEDS_UPDATE. Unrelated to this change though.
There was a problem hiding this comment.
As we're committing to master here, we could just check if HEAD != origin/master. Just need to figure out an elegant way to pull that out of git.
There was a problem hiding this comment.
Will do that in a separate PR.
This was referenced Apr 1, 2021
sync: run go mod tidy (and set Go 1.15) and gofmt -s in copy workflow
multiformats/go-multistream#59
Merged
Merged
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.