Feature/gelato integration #1481
Conversation
|
Sneak Peak!
|
There was a problem hiding this comment.
Very cool feature! Definitely needed, overall works great! Just found couple of small things that will be easy fix:
- As you can see in this screenshot seems that fields are not vertically aligned
- Is it accounted for if market has duration that is shorter than 3 days?
- Also i don't know if it's scope of this issue but seems that "Your liquidity" in pool section stops working
- Some parts of this text should be bolded like in desings
- This market is in test http://localhost:3000/#/0x915883aa30752c374527655192c2d9161d54e268 i created it with 12 dai via gelato and deposited 100 dai via gelato (this is just for future reference so i can test it)
Fixed. Also FYI your screenshot has an icon that's a bit fishy (next to the word 'time' that icon should be hidden and is for me) maybe you are behind a few commits somehow?
We added that, thanks!
Hmm... not sure either might also be related to the first point. Is it that the amount of liquidity displayed in "Your Liquidity" wont update or is it that a button won't activate on click?
Done thanks. Let me know if anything else is needed or if there are any issues with the changes. Thanks! |
|
There was a problem hiding this comment.
I found two things regarding gelato withdrawing and when market is resolved and auto-withdraw feature activates
- When i deposit liquidity with auto-withdraw and then withdraw before the period ends
nothing changes in the ui below is ui after i withdraw
after i refresh the page correct data is shown
- When i stay in market view when liquidity is to be auto-withdrawn timer goes into negative and doesn't show correct data only on refresh does it change
Hi we've pushed changes recently that should be fixing this (just tested and verified that after a cancel, it updated itself without refresh, it worked). It's possible that we were criss crossed a bit and you were still a commit or two behind, when you got that. The 'need to refresh' error should have been fixed by this commit. There is a chance that A) you were a commit or two behind (no worries since we pushed very recently) or B) subgraph was just being very slow to update? |
Yeah it is that i was testing it this afternoon! |
|
That seems to be general issue with Apollo, I have encountered that one before on other dApps, dont think it has smth to do with Gelato. apollographql/react-apollo#2813 |
Yeah it seems to be the case! |
|
This repository is now up to date after rebase and commit to fix small new issues now that scalar markets have been integrated. Note that currently, Gelato auto-withdrawls will only be available for categorical markets. In my opinion, integrating Gelato for scalar markets is outside the scope of this pr and can be handled separately but let me know what y'all think. Lastly, we're doing the last minor styling corrections in this pr so these changes are easier to find and discuss. |
|
Pushed another rebase, and updated some ethereum addresses and config urls for production. Just a note that if you want to test gelato on Mainnet, we have reinstated the graphql urls to point to the protofire subgraph, but it seems only rinkeby subgraph has been deployed and synced to include gelato. Either sync the new mainnet subgraph (that includes gelato) before testing, or just reset these two variables in the |
|
closing in favor of #1691 |
Hello Omen!
This pr is the last piece of Gelato's integration with Omen, allowing for Omen users to schedule an auto-withdraw of liquidity provided to a prediction market. Gelato handles transaction execution at the user specified auto-withdraw date, and the executor recoups the transaction fees by taking a portion of the liquidity withdrawn (the rate is calculated on chain using oracles for token and gas prices). As such we impose a minimum threshold on liquidity deposited before Gelato can be activated, since it doesn't make sense to use Gelato if the entire deposit amount being withdrawn automatically won't even cover the transaction fee (and we can only guess what the transaction fee will be at the future date of execution)
Also note that this PR works with an omen-subgraph that includes Gelato data. We have made a PR that is ready to be merged for that here
Finally, there is a helpful constant for Omen devs
GELATO_ACTIVATEDthat easily hides the Gelato features completely from the UI, which should be useful for e.g. xDai sidechain development (as Gelato services can only be used on main chain transactions)Happy holidays!