Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial implementation #1

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat: initial implementation #1

wants to merge 24 commits into from

Conversation

allemanfredi
Copy link
Contributor

as per title ...

@allemanfredi allemanfredi added the enhancement New feature or request label Nov 9, 2022
@allemanfredi allemanfredi self-assigned this Nov 9, 2022
Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are good so far but the agreement contract's token balance needs to be asserted as well wherever where you've asserted claimant's token balances.

Otherwise, see inline comments re the contract itself. Some things should definitely be changed, others are suggestions and other probably need further discussion.

Let me know if I've misunderstood anything too please!

contracts/Agreement.sol Show resolved Hide resolved
contracts/Agreement.sol Show resolved Hide resolved
contracts/Agreement.sol Show resolved Hide resolved
contracts/Agreement.sol Outdated Show resolved Hide resolved
contracts/Agreement.sol Outdated Show resolved Hide resolved
contracts/Agreement.sol Show resolved Hide resolved
contracts/Agreement.sol Show resolved Hide resolved
test/Agreement.test.js Outdated Show resolved Hide resolved
test/Agreement.test.js Show resolved Hide resolved
test/Agreement.test.js Show resolved Hide resolved
Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your last example explained all the design decisions and settled any last queries I had.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants