Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of direct color definitions in styled components #1410

Closed
abelgibayev opened this issue Jan 19, 2022 · 0 comments
Closed

Get rid of direct color definitions in styled components #1410

abelgibayev opened this issue Jan 19, 2022 · 0 comments
Assignees
@Dekshut
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/refactoring
Milestone
0.4

Comments

@abelgibayev
Copy link
Contributor

Describe the bug
Some styled components use colours directly, without a theme. Replace such places to theme approach in all places. Add the colors to the theme if they are missing.

Additional context

kafka-ui/kafka-ui-react-app/src/components/App.styled.ts

Line 29 in 439d41d

border-right: 1px solid #e7e7e7;

@provectus provectus deleted a comment from github-actions bot Jan 19, 2022
@Haarolean Haarolean added status/accepted An issue which has passed triage and has been accepted good first issue Up for grabs labels Jan 19, 2022
@Haarolean Haarolean linked a pull request Jan 19, 2022 that will close this issue
[Draft] edited colors formats in styled components #1423
Closed
13 tasks
@Haarolean Haarolean removed the type/bug Something isn't working label Jan 19, 2022
@Haarolean Haarolean added this to the 0.4 milestone Jan 19, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this issue Dec 7, 2022
@Dekshut @workshur
[Fixes provectus#1410] Edited using colors in styled components using…
e8ae688 
… our Theme (provectus#1442)

* Edited using colors in syled components

* updated snapshots

* updated snapshots

* edited stylistic mistake

Co-authored-by: Oleg Shur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dekshut Dekshut

Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/refactoring
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

[Draft] edited colors formats in styled components provectus/kafka-ui
3 participants
@Haarolean @abelgibayev @Dekshut