Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a popup warning about deleting topic messages. #1324

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Added a popup warning about deleting topic messages. #1324

merged 3 commits into from
Jan 10, 2022

Conversation

NelyDavtyan
Copy link
Contributor

@NelyDavtyan NelyDavtyan commented Dec 27, 2021 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Issues #1229
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@workshur workshur merged commit b5aa86c into master Jan 10, 2022
@workshur workshur deleted the issues/1229 branch January 10, 2022 13:34
@Haarolean Haarolean mentioned this pull request Jan 11, 2022
Closed
@Haarolean Haarolean added scope/frontend redesign type/enhancement En enhancement to an already existing feature labels Jan 11, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@NelyDavtyan
Added a popup warning about deleting topic messages. (provectus#1324)
20d1d09 
* Added a popup warning about deleting topic messages.

* Added test for warning popup.

* Small fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workshur workshur workshur approved these changes

@Hurenka Hurenka Awaiting requested review from Hurenka

Assignees
No one assigned
Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NelyDavtyan @workshur @Haarolean