Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/1217 #1430

Merged
merged 10 commits into from
Jan 20, 2022
Merged

Issues/1217 #1430

merged 10 commits into from
Jan 20, 2022

Conversation

Hurenka
Copy link
Contributor

@Hurenka Hurenka commented Jan 19, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 19, 2022
@Haarolean Haarolean linked an issue Jan 19, 2022 that may be closed by this pull request
Space sensitive syntax for Create Connector #1217
Closed
@Haarolean Haarolean added redesign scope/frontend type/bug Something isn't working and removed status/triage Issues pending maintainers triage labels Jan 19, 2022
@Hurenka Hurenka merged commit 2b79fee into master Jan 20, 2022
@Hurenka Hurenka deleted the issues/1217 branch January 20, 2022 12:26
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workshur workshur workshur approved these changes

@Motherships Motherships Motherships approved these changes

@NelyDavtyan NelyDavtyan NelyDavtyan approved these changes

Assignees

@Hurenka Hurenka

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space sensitive syntax for Create Connector
5 participants
@Hurenka @workshur @Motherships @NelyDavtyan @Haarolean