Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polling timeouts made configurable #3513

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Polling timeouts made configurable #3513

merged 5 commits into from
Mar 21, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Mar 17, 2023

  1. Polling timeouts made configurable
  2. polling-related classes moved to emitter package
  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

1. Polling timeouts made configurable
809daab 
2. polling-related classes moved to emitter package
@iliax iliax requested a review from a team as a code owner March 17, 2023 09:32
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Mar 17, 2023
@iliax iliax linked an issue Mar 17, 2023 that may be closed by this pull request
UI gives up after 3000ms of trying to read messages and shows "no messages" falsely #3485
Closed
@iliax iliax requested a review from Haarolean March 17, 2023 10:42
iliax added 2 commits March 20, 2023 15:37
polling properties added to wizard api
6f94c27
Merge branch 'master' of github.com:provectus/kafka-ui into configura…
151773b 
…tble_polling_settings

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/ClustersProperties.java
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Haarolean Haarolean added type/bug Something isn't working scope/backend and removed status/triage Issues pending maintainers triage labels Mar 21, 2023
@iliax iliax merged commit bd6394c into master Mar 21, 2023
@iliax iliax deleted the configuratble_polling_settings branch March 21, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees

@iliax iliax

Labels
scope/backend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI gives up after 3000ms of trying to read messages and shows "no messages" falsely
2 participants
@iliax @Haarolean