Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP 400 for clusters with special symbols #3591

Merged
merged 1 commit into from
Apr 3, 2023
Merged

HTTP 400 for clusters with special symbols #3591

merged 1 commit into from
Apr 3, 2023

Conversation

NeiruBugz
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves #3290
Add encoding for clusterName URL parameter
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@NeiruBugz NeiruBugz requested a review from a team as a code owner March 30, 2023 10:45
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Mar 30, 2023
@NeiruBugz NeiruBugz added type/bug Something isn't working scope/frontend and removed status/triage Issues pending maintainers triage labels Mar 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@workshur workshur requested a review from Haarolean March 30, 2023 14:24
@Haarolean Haarolean merged commit ecc8db1 into master Apr 3, 2023
@Haarolean Haarolean deleted the bugfix/cluster-name-encoding branch April 3, 2023 04:47
Haarolean pushed a commit that referenced this pull request Apr 13, 2023
@NeiruBugz @Haarolean
FE: Fix HTTP 400 for clusters with special symbols (#3591)
b0c367c 
(cherry picked from commit ecc8db1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workshur workshur workshur approved these changes

@Mgrdich Mgrdich Mgrdich approved these changes

@Haarolean Haarolean Awaiting requested review from Haarolean

Assignees

@Haarolean Haarolean

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP 400 for clusters with special symbols
4 participants
@NeiruBugz @workshur @Mgrdich @Haarolean