Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Fix latest version is null #3833

Merged
merged 2 commits into from
May 22, 2023
Merged

FE: Fix latest version is null #3833

merged 2 commits into from
May 22, 2023

Conversation

David-DB88
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
changed warning message on version warning icon
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@David-DB88 David-DB88 added scope/frontend status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels May 17, 2023
@David-DB88 David-DB88 requested a review from Mgrdich May 17, 2023 09:31
@David-DB88 David-DB88 self-assigned this May 17, 2023
@David-DB88 David-DB88 linked an issue May 17, 2023 that may be closed by this pull request
FE: Latest version is null #3818
Closed
@David-DB88 David-DB88 marked this pull request as ready for review May 17, 2023 09:32
@David-DB88 David-DB88 requested a review from a team as a code owner May 17, 2023 09:32
@github-actions
Copy link

Custom deployment will be available at http://pr3833.internal.kafka-ui.provectus.io

@Haarolean Haarolean added type/bug Something isn't working and removed status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels May 17, 2023
@github-actions
Copy link

Custom deployment removed

@Haarolean Haarolean changed the title Implement Missing latest version #3818 FE: Fix latest version is null May 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean merged commit f22c910 into master May 22, 2023
@Haarolean Haarolean deleted the Implement_Missing_latest_version_#3818 branch May 22, 2023 10:09
Haarolean pushed a commit that referenced this pull request Jun 27, 2023
@David-DB88 @Haarolean
FE: Fix latest version is null (#3833)
aa633f4 
Co-authored-by: Roman Zabaluev <[email protected]>
(cherry picked from commit f22c910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mgrdich Mgrdich Mgrdich approved these changes

Assignees

@David-DB88 David-DB88

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Latest version is null
3 participants
@David-DB88 @Mgrdich @Haarolean