Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Fix cognito roles extractor regression #4171

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

FreddyMcRay
Copy link
Contributor

@FreddyMcRay FreddyMcRay commented Aug 29, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #4157

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there FreddyMcRay! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@FreddyMcRay FreddyMcRay marked this pull request as ready for review August 29, 2023 16:07
@FreddyMcRay FreddyMcRay requested a review from a team as a code owner August 29, 2023 16:07
@Haarolean Haarolean added type/bug Something isn't working scope/backend labels Aug 30, 2023
@Haarolean Haarolean changed the title fix #4157: cognito groups matching fixed BE: Fix cognito roles extractor regression Aug 30, 2023
@Haarolean Haarolean merged commit 729ca79 into provectus:master Aug 30, 2023
10 checks passed
@Haarolean
Copy link
Contributor

@FreddyMcRay thank you!

gimral pushed a commit to gimral/kafka-ui that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC: Cognito roles matching regression
2 participants