Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/cosmos/ibc-go/v2 from 2.2.0 to 2.3.0 #868

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 15, 2022

Bumps github.com/cosmos/ibc-go/v2 from 2.2.0 to 2.3.0.

Release notes

Sourced from github.com/cosmos/ibc-go/v2's releases.

v2.3.0

Please note that, according to ibc-go's semantic versioning, this release requires a coordinated upgrade because it contains state-machine breaking changes. This release requires also running a migration.

This release bumps the Go version to v1.17 and the Cosmos SDK to v0.45.4 (for more information, see Cosmos SDK v0.45.4 Release Notes), and introduces several improvements and bug fixes. We present here a summary of the most relevant changes, but please see the v2.3.0 changelog for the full set of changes included in this release.

core/02-client

  • A gRPC query method and CLI query has been added to retrieve the heights of all consensus states associated with the a given client ID.

core/04-channel

apps/transfer

  • The DenomTrace gRPC method and CLI query can now take as argument either a trace hash or a full IBC denom prefixed with ibc/.
  • The sender address is now added in the event emitted in the OnRecvPacket and OnAcknowledgementPacket callbacks.
  • A gRPC query method has been added to retrieve the escrow address for a particular channel.
  • Support for token transfers of coins whose base denomination contains slashes has been added. For the transfer of coins whose base denomination contains slashes to succeed, both the sending and the receiving chains need to upgrade to add this support. Please follow also the migration guide.

light-clients/07-tendermint

Special thanks to our external contributors on this release: @​catShaark @​fedekunze


To learn more about ibc-go versioning, please read our RELEASES.md.

IMPORTANT: Please read the migration guides for any versions of ibc-go that you might be going through when upgrading to this version. For example: if you upgrade from the IBC module contained in the Cosmos SDK 0.42.0 to SDK v0.45.4 and ibc-go v2.3.0, please follow:

  1. The migration from SDK 0.41.x or 0.42.x to the IBC module in the ibc-go repository based on the SDK v0.44.x.
  2. The migration from ibc-go v1 to v2.
  3. The migration to add support for transfers of tokens whose base denomination contains slashes.

v2.2.1

This release introduces some improvements and bug fixes. We present here the most relevant changes, but please see the v2.2.1 changelog for the full set of changes included in this release.

core/04-channel

apps/transfer

Special thanks to our external contributors on this release: @​catShaark @​fedekunze


... (truncated)

Changelog

Sourced from github.com/cosmos/ibc-go/v2's changelog.

v2.3.0 - 2022-04-16

Dependencies

  • #404 Bump Go version to 1.17
  • #1300 Bump SDK version to v0.45.4

Improvements

  • (transfer) #1342 DenomTrace grpc now takes in either an ibc denom or a hash instead of only accepting a hash.
  • (modules/core/04-channel) #1160 Improve uint64 -> string performance in Logger.
  • (modules/core/keeper) #1284 Add sanity check for the keepers passed into ibckeeper.NewKeeper. ibckeeper.NewKeeper now panics if any of the keepers passed in is empty.
  • (transfer) #1414 Emitting Sender address from fungible_token_packet events in OnRecvPacket and OnAcknowledgementPacket.
  • (modules/core/04-channel) #1464 Emit a channel close event when an ordered channel is closed.
  • (modules/light-clients/07-tendermint) #1118 Deprecating AllowUpdateAfterExpiry and AllowUpdateAfterMisbehaviour. See ADR-026 for context.

Features

  • (modules/core/02-client) #1336 Adding Query/ConsensusStateHeights gRPC for fetching the height of every consensus state associated with a client.
  • (modules/apps/transfer) #1416 Adding gRPC endpoint for getting an escrow account for a given port-id and channel-id.

Bug Fixes

  • (modules/core/04-channel) #1130 Call packet.GetSequence() rather than passing func in WriteAcknowledgement log output
  • (apps/transfer) #1451 Fixing the support for base denoms that contain slashes.

v2.2.1 - 2022-04-16

Improvements

  • (transfer) #1342 DenomTrace grpc now takes in either an ibc denom or a hash instead of only accepting a hash.
  • (modules/core/04-channel) #1160 Improve uint64 -> string performance in Logger.
  • (modules/core/keeper) #1284 Add sanity check for the keepers passed into ibckeeper.NewKeeper. ibckeeper.NewKeeper now panics if any of the keepers passed in is empty.
  • (transfer) #1414 Emitting Sender address from fungible_token_packet events in OnRecvPacket and OnAcknowledgementPacket.
  • (modules/core/04-channel) #1464 Emit a channel close event when an ordered channel is closed.

Bug Fixes

  • (modules/core/04-channel) #1130 Call packet.GetSequence() rather than passing func in WriteAcknowledgement log output
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.3.0/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 15, 2022
Copy link
Contributor

@dwedul-figure dwedul-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to also require an update to the protos, so one of us will need to take over.

Copy link
Contributor

@dwedul-figure dwedul-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to look more into that snapshot.proto file. I'm not sure if it's gone from cosmos or just from our fork. Might be worth a different PR though, but we'll see.

@dwedul-figure
Copy link
Contributor

I need to look more into that snapshot.proto file. I'm not sure if it's gone from cosmos or just from our fork. Might be worth a different PR though, but we'll see.

Looks like proto/cosmos/base/store/v1beta1/snapshot.proto existed in v0.45.1 but not v0.45.2.
In our own fork, v0.45.0-pio-1 has the file, but these do not: v0.45.3-pio, v0.45.3-pio-2, and v0.45.4-pio-1.

I'm not sure why we weren't alerted to the existence of that file previously (specially when doing all the tweaks and automation of that check).

But what that means is that, with this change, there's a breaking proto change in the third_party stuff. It's breaking because the file is being removed. From Cosmos-SDK PR 10961, it looks like those messages were moved and the failing breaking proto check was ignored.

In my opinion, we should also remove the file. The messages defined in there aren't used anywhere that I can find, and are defined in proto/cosmos/base/snapshots/v1beta1/snapshot.proto. I also feel that it'd be weird to keep it around since it's been deleted by the third party. That means that our own third party proto breaking check will fail for this PR. The other checks in that job should pass though.

@dwedul-figure dwedul-figure enabled auto-merge (squash) June 15, 2022 17:45
@dwedul-figure dwedul-figure merged commit 1e09b46 into main Jun 23, 2022
@dwedul-figure dwedul-figure deleted the dependabot/go_modules/github.com/cosmos/ibc-go/v2-2.3.0 branch June 23, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants