Convert self.hardware to Ordered Dict #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tware into ordered_dict_issue
…tpy_flight_software into ordered_dict_issue
|
Thanks for submitting this! I will test it on our Engineering Model tomorrow and if it runs well I will approve the pull request! |
|
Ran it and LGTM! We might want to check down the line for any edge case issues with unpacking the dict into state of health stuff but it shouldn't be an issue. |
Mikefly123
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37.
All references to the hardware field have been checked and should work properly. I also slightly re-ordered the dictionary to align with the order of initialization.