feat(aws): Add new RDS check for deletion protection enabled on clusters #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4738 +/- ##
==========================================
+ Coverage 89.06% 89.11% +0.04%
==========================================
Files 914 921 +7
Lines 27970 28140 +170
==========================================
+ Hits 24912 25077 +165
- Misses 3058 3063 +5 ☔ View full report in Codecov by Sentry. |
MrCloudSec
reviewed
Aug 14, 2024
| "RelatedUrl": "https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_DeleteInstance.html", | ||
| "Remediation": { | ||
| "Code": { | ||
| "CLI": "aws rds modify-db-instance --db-instance-identifier <db_instance_id> --deletion-protection --apply-immediately", |
There was a problem hiding this comment.
Please, change the CLI command for the cluster one.
MrCloudSec
requested changes
Aug 14, 2024
|
Yes, good point. We can do it the same way we did in #4730 |
MrCloudSec
force-pushed
the
PRWLR-4525-rds-clusters-should-have-deletion-protection-enabled
branch
from
f397b7e
to
36c1828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new check will verify that deletion protection is enabled for Amazon RDS DB clusters. Enabling deletion protection provides a critical safeguard against accidental or unauthorized deletions, ensuring that the clusters cannot be removed without explicitly disabling this setting first.
When you try to create a new RDS database, there is an option in the additional configuration that allows you to enable deletion protection with the following description: "Protects the database from being deleted accidentally. While this option is enabled, you can’t delete the database." This check verifies that every DB cluster has this option enabled.
Description
I added
rds_cluster_deletion_protectionwith its respective unit test.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.