feat(aws): Add new RDS check to ensure db clusters are configured for multiple availability zones #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4781 +/- ##
==========================================
- Coverage 89.13% 89.06% -0.08%
==========================================
Files 921 927 +6
Lines 28157 28383 +226
==========================================
+ Hits 25099 25278 +179
- Misses 3058 3105 +47 ☔ View full report in Codecov by Sentry. |
puchy22
reviewed
Aug 20, 2024
| class rds_cluster_multi_az(Check): | ||
| def execute(self): | ||
| findings = [] | ||
| for db_cluster in rds_client.db_clusters: |
There was a problem hiding this comment.
To iterate over a dict in Python I recommend you to use items() it will retrieve the key and the value in the same iteration.
Suggested change
| for db_cluster in rds_client.db_clusters: | |
| for db_cluster_arn, db_cluster in rds_client.db_clusters.items(): |
There was a problem hiding this comment.
Thanks for your advice! 😄
MrCloudSec
reviewed
Aug 21, 2024
MrCloudSec
reviewed
Aug 21, 2024
MrCloudSec
reviewed
Aug 21, 2024
MrCloudSec
requested changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new check verifies that Amazon RDS DB clusters are configured to operate across multiple Availability Zones (AZs), enhancing high availability and resilience.
Since the Multi-AZ attribute is heritable from clusters to instances, I've modified the instance check to only scan instances that are not part of a cluster. Instances that are clustered are already covered by this new check.
For testing, while Moto supports the creation of instances with MultiAZ, it does not support MultiAZ on clusters. Therefore, I've had to use MagicMock for the cluster tests.
Description
I added
rds_cluster_multi_azwith its respective unit test and modifiedrds_instance_multi_azand its respective unit test.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.