Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): change description from documentdb_cluster_deletion_protection #4909

Conversation

pedrooot
Copy link
Member

Context

Fix #4906

Description

Change check metadata description from documentdb_cluster_deletion_protection
From : Check if Neptune Clusters has deletion protection enabled.
To: Check if DocumentDB Clusters has deletion protection enabled.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (163027a) to head (4be330f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4909   +/-   ##
=======================================
  Coverage   89.03%   89.03%           
=======================================
  Files         937      937           
  Lines       28709    28709           
=======================================
+ Hits        25560    25561    +1     
+ Misses       3149     3148    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas self-requested a review September 2, 2024 07:58
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jfagoagas jfagoagas merged commit 007c1fe into master Sep 2, 2024
11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-4745-gh-issue-incorrect-description-in-documentdb-cluster-deletion-protection-metadata-json-for-document-db-4906 branch September 2, 2024 07:59
prowler-bot pushed a commit that referenced this pull request Sep 2, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Sep 2, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Description in documentdb_cluster_deletion_protection.metadata.json for DocumentDB
4 participants