feat(aws): Add new check to ensure RDS instances are not using default database engine ports #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4973 +/- ##
==========================================
+ Coverage 89.05% 89.10% +0.04%
==========================================
Files 968 969 +1
Lines 29618 29642 +24
==========================================
+ Hits 26376 26412 +36
+ Misses 3242 3230 -12 ☔ View full report in Codecov by Sentry. |
MrCloudSec
reviewed
Sep 18, 2024
| @@ -0,0 +1,32 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "rds_instance_not_default_port", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "rds_instance_not_default_port", | |
| "CheckID": "rds_instance_non_default_port", |
MrCloudSec
reviewed
Sep 18, 2024
| "CheckID": "rds_instance_not_default_port", | ||
| "CheckTitle": "Check if RDS instances are using non-default ports.", | ||
| "CheckType": [ | ||
| "Software and Configuration Checks, AWS Security Best Practices" |
There was a problem hiding this comment.
Suggested change
| "Software and Configuration Checks, AWS Security Best Practices" | |
| "Software and Configuration Checks", "AWS Security Best Practices" |
MrCloudSec
reviewed
Sep 18, 2024
Comment on lines
47
to
52
| if check_security_group( | ||
| ingress_rule, | ||
| "tcp", | ||
| [db_instance.port], | ||
| any_address=True, | ||
| ): |
There was a problem hiding this comment.
This will only check if the port is public, not if it can be accessed by an IP address, is that what we want?
There was a problem hiding this comment.
I would only check the ports for each instance in db_instance.port.
MrCloudSec
reviewed
Sep 18, 2024
| class rds_instance_not_default_port(Check): | ||
| def execute(self): | ||
| findings = [] | ||
| default_ports = { |
There was a problem hiding this comment.
Where did you get this list from?
MrCloudSec
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new check verifies if an instance uses a port other than the default port of the database engine. The control fails if the RDS instance uses the default port or a non-default port that is not configured in the security group.
Since RDS instances belong to VPC Security Groups, which are managed by EC2, I've used this service to iterate over all the security groups and verify if an instance belongs to any of them. If so, I've checked that the security group has the port that the instance is listening to open. With this implementation, I can verify that if the instance uses a non-default port, it's configured correctly in the security group.
Description
Added
rds_instance_not_default_portcheck with its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.