-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code #5061
Merged
MrCloudSec
merged 4 commits into
master
from
PRWLR-4336-add-new-inspector-check-for-ecr-ec-2-lambda-scanning-enabled
Sep 17, 2024
Merged
fix(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code #5061
MrCloudSec
merged 4 commits into
master
from
PRWLR-4336-add-new-inspector-check-for-ecr-ec-2-lambda-scanning-enabled
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the resources and adjust service and check tests to the changes
github-actions
bot
added
the
provider/aws
Issues/PRs related with the AWS provider
label
Sep 17, 2024
MarioRgzLpz
changed the title
Prwlr 4336 add new inspector check for ecr ec 2 lambda scanning enabled
feat(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code
Sep 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5061 +/- ##
==========================================
+ Coverage 88.97% 89.01% +0.04%
==========================================
Files 957 962 +5
Lines 29340 29469 +129
==========================================
+ Hits 26105 26233 +128
- Misses 3235 3236 +1 ☔ View full report in Codecov by Sentry. |
MrCloudSec
reviewed
Sep 17, 2024
prowler/providers/aws/services/inspector2/inspector2_service.py
Outdated
Show resolved
Hide resolved
MrCloudSec
reviewed
Sep 17, 2024
prowler/providers/aws/services/inspector2/inspector2_is_enabled/inspector2_is_enabled.py
Outdated
Show resolved
Hide resolved
MrCloudSec
reviewed
Sep 17, 2024
tests/providers/aws/services/inspector2/inspector2_is_enabled/inspector2_is_enabled_test.py
Outdated
Show resolved
Hide resolved
MrCloudSec
changed the title
feat(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code
chore(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code
Sep 17, 2024
MrCloudSec
approved these changes
Sep 17, 2024
MrCloudSec
changed the title
chore(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code
fix(inspector2): Ensure Inspector2 is enabled for ECR, EC2, Lambda and Lambda Code
Sep 17, 2024
MrCloudSec
deleted the
PRWLR-4336-add-new-inspector-check-for-ecr-ec-2-lambda-scanning-enabled
branch
September 17, 2024 18:01
prowler-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
…d Lambda Code (#5061) Co-authored-by: Sergio Garcia <[email protected]> (cherry picked from commit c425e82) # Conflicts: # prowler/providers/aws/services/inspector2/inspector2_is_enabled/inspector2_is_enabled.py
prowler-bot
added
the
was-backported
The PR was successfully backported to the target branch
label
Sep 17, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-to-v3
Backport PR to the v3 branch
provider/aws
Issues/PRs related with the AWS provider
was-backported
The PR was successfully backported to the target branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To improve security and ensure adherence to best practices for container image protection, we are introducing a new check within the Amazon Inspector framework. This check ensures that the new version of Amazon Inspector is enabled in order to help you improve the security and compliance of your AWS cloud environment. Amazon Inspector 2 is a vulnerability management solution that continually scans scans your Amazon EC2 instances, ECR container images, and Lambda functions to identify software vulnerabilities and instances of unintended network exposure.
Description
Change old check
inspector2_is_enabled.py
to add the new check logic. Change the metadata and test to adjust to the new check. Added 4 new attributes for the resources status to theInspector
Model in inspector2_service
. Adjust other check and service tests to the service changes.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.