Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): solve errors in GCP services #5123

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(gcp): solve errors in GCP services #5123

merged 2 commits into from
Sep 20, 2024

Conversation

prowler-bot
Copy link
Collaborator

Backport

This will backport the following commits from master to v3:

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 16a2512)

# Conflicts:
#	prowler/providers/gcp/services/kms/kms_key_rotation_enabled/kms_key_rotation_enabled.py
#	tests/providers/gcp/services/kms/kms_key_rotation_enabled/kms_key_rotation_enabled_test.py
@prowler-bot prowler-bot requested review from a team as code owners September 20, 2024 15:07
@prowler-bot prowler-bot added the backport This PR contains a backport label Sep 20, 2024
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.86%. Comparing base (85d5f19) to head (85b91fa).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
.../providers/gcp/services/compute/compute_service.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #5123      +/-   ##
==========================================
+ Coverage   86.84%   86.86%   +0.01%     
==========================================
  Files         714      716       +2     
  Lines       22529    22569      +40     
==========================================
+ Hits        19566    19604      +38     
- Misses       2963     2965       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit f3863e9 into v3 Sep 20, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the backport/v3/pr-5016 branch September 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR contains a backport provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants