Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regions): show all for empty regions #5143

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Sep 23, 2024

Description

Add "all" in banner for regions when executing prowler for aws.
Screenshot 2024-09-23 at 11 17 07

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners September 23, 2024 09:03
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.99%. Comparing base (6f57c27) to head (651f179).
Report is 17 commits behind head on v4.3.

Additional details and impacted files
@@            Coverage Diff             @@
##             v4.3    #5143      +/-   ##
==========================================
+ Coverage   88.95%   88.99%   +0.03%     
==========================================
  Files         910      910              
  Lines       27745    27764      +19     
==========================================
+ Hits        24681    24709      +28     
+ Misses       3064     3055       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for all regions, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@MrCloudSec MrCloudSec self-requested a review September 23, 2024 12:48
@MrCloudSec MrCloudSec merged commit 4bb2857 into v4.3 Sep 23, 2024
10 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4900-regions-still-not-showing-right-on-4-3-6 branch September 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants