feat(networkfirewall): change network_firewalls from list to dict
#5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
pedrooot
requested changes
Sep 24, 2024
puchy22
previously requested changes
Sep 24, 2024
| @@ -27,13 +27,14 @@ def _list_firewalls(self, regional_client): | |||
| network_firewall["FirewallArn"], self.audit_resources | |||
| ) | |||
| ): | |||
| self.network_firewalls.append( | |||
| self.network_firewalls[network_firewall.get("FirewallArn")] = ( | |||
There was a problem hiding this comment.
Suggested change
| self.network_firewalls[network_firewall.get("FirewallArn")] = ( | |
| self.network_firewalls[network_firewall.get("FirewallArn", "")] = ( |
| @@ -27,13 +27,14 @@ def _list_firewalls(self, regional_client): | |||
| network_firewall["FirewallArn"], self.audit_resources | |||
| ) | |||
| ): | |||
| self.network_firewalls.append( | |||
| self.network_firewalls[network_firewall.get("FirewallArn")] = ( | |||
| Firewall( | |||
| arn=network_firewall.get("FirewallArn"), | |||
There was a problem hiding this comment.
Please could you remove the ARN from the model since that information is already in the key
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5169 +/- ##
==========================================
+ Coverage 89.12% 89.24% +0.11%
==========================================
Files 976 976
Lines 29909 29951 +42
==========================================
+ Hits 26657 26730 +73
+ Misses 3252 3221 -31 ☔ View full report in Codecov by Sentry. |
MrCloudSec
approved these changes
Sep 24, 2024
MrCloudSec
deleted the
PRWLR-4915-change-firewalls-from-list-to-dict
branch
HugoPBrito
added a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
network_firewallsvariable is a list, but this does not align with other services structure and scalability.Description
network_firewallshas been changed from list to dict. This change will improve performance when accessing this variable and make the code more readable and maintainable. The new structure maintains backward compatibility and include necessary adjustments to any methods or functions interacting with the firewall list.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.