chore(ec2): enhance security group with any open port check #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5215 +/- ##
==========================================
- Coverage 89.10% 89.07% -0.04%
==========================================
Files 993 993
Lines 30510 30509 -1
==========================================
- Hits 27187 27176 -11
- Misses 3323 3333 +10 ☔ View full report in Codecov by Sentry. |
…group-allow-ingress-from-internet-to-any-port
jfagoagas
previously approved these changes
Sep 30, 2024
…group-allow-ingress-from-internet-to-any-port
jfagoagas
reviewed
Sep 30, 2024
| @@ -650,7 +649,7 @@ def test_ec2_non_compliant_default_sg_pass_to_avoid_fail_twice(self): | |||
| "SecurityGroups" | |||
| ][0] | |||
| default_sg_id = default_sg["GroupId"] | |||
| default_sg_name = default_sg["GroupName"] | |||
| default_sg["GroupName"] | |||
There was a problem hiding this comment.
Suggested change
| default_sg["GroupName"] | |
| default_sg["GroupName"] |
jfagoagas
approved these changes
Sep 30, 2024
MrCloudSec
deleted the
PRWLR-4920-false-positive-on-ec-2-securitygroup-allow-ingress-from-internet-to-any-port
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix #5172.
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.