fix(aws): handle none type attributes

[sergargar]

Description

Handle None type attributes in checks:

• organizations_scp_check_deny_regions
• ecr_repositories_not_publicly_accessible

Also, fix typo in work accessible.

Checklist

• Are there new checks included in this PR? Yes / No
  • If so, do we need to update permissions for the provider? Please review this carefully.
• Review if the code is being covered by tests.
• Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
• Review if backport is needed.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (ff05ce4) to head (62b0882).
Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
...ny_regions/organizations_scp_check_deny_regions.py	77.77%	8 Missing ⚠️
...ws/services/organizations/organizations_service.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5216      +/-   ##
==========================================
- Coverage   89.11%   89.10%   -0.01%     
==========================================
  Files         986      989       +3     
  Lines       30290    30400     +110     
==========================================
+ Hits        26992    27087      +95     
- Misses       3298     3313      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jfagoagas]

Could you please add tests for the following lines:

• 74
• 82 to 85
• 88 to 90

If we are changing the logic of the check we should cover those scenarios.

[sergargar]

@jfagoagas the logic of the check was not changed, only the following line was added:
if org.policies is not None: # Access denied to list policies

[jfagoagas]

Yes but even with that I think those lines are not being tested, you should add a test to verify when org.policies is None, don't you?

[sergargar]

Yes, test was added!

[jfagoagas]

Great one, thanks @sergargar 🚀