-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(securityhub): add tags securityhub_enabled
#5231
feat(securityhub): add tags securityhub_enabled
#5231
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5231 +/- ##
==========================================
+ Coverage 89.09% 89.15% +0.06%
==========================================
Files 987 988 +1
Lines 30335 30374 +39
==========================================
+ Hits 27028 27081 +53
+ Misses 3307 3293 -14 ☔ View full report in Codecov by Sentry. |
@@ -85,6 +87,18 @@ def _describe_hub(self, regional_client): | |||
f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | |||
) | |||
|
|||
def _list_tags(self, resource: any): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check here not to do it for Hub with NOT_AVAILABLE
status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the ARN would be an account ARN and therefore, not valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved!
Context
Add missing tags to
securityhub_enabled
report.Description
securityhub_enabled
.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.