feat(ecs): Ensure ECS containers have a logging configuration specified #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
sergargar
requested changes
Sep 27, 2024
| "Software and Configuration Checks/AWS Security Best Practices" | ||
| ], | ||
| "ServiceName": "ecs", | ||
| "SubServiceName": "taskDefinition", |
There was a problem hiding this comment.
Suggested change
| "SubServiceName": "taskDefinition", | |
| "SubServiceName": "", |
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "ecs_task_definition_containers_log_enabled", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "ecs_task_definition_containers_log_enabled", | |
| "CheckID": "ecs_task_definitions_logging_enabled", |
There was a problem hiding this comment.
Put the task revision in the status extended as in ecs_task_definitions_host_namespace_not_shared, can you do it for those checks that do not have it either, please?
…eck-to-ensure-a-logging-configuration-is-specified
…SubServiceName in metadata
…-a-logging-configuration-is-specified' of github.com:prowler-cloud/prowler into PRWLR-4311-add-new-ecs-task-definitions-check-to-ensure-a-logging-configuration-is-specified
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5234 +/- ##
=======================================
Coverage 89.11% 89.12%
=======================================
Files 988 989 +1
Lines 30364 30387 +23
=======================================
+ Hits 27060 27083 +23
Misses 3304 3304 ☔ View full report in Codecov by Sentry. |
sergargar
deleted the
PRWLR-4311-add-new-ecs-task-definitions-check-to-ensure-a-logging-configuration-is-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This check verifies whether the latest active Amazon ECS task definition has a logging configuration specified. The check fails if the task definition lacks the logConfiguration property or if the logDriver value is null in any container definition.
Logging helps you maintain the reliability, availability, and performance of Amazon ECS. Collecting data from task definitions provides visibility, which can help you debug processes and find the root cause of errors. If you are using a logging solution that does not have to be defined in the ECS task definition (such as a third party logging solution), you can disable this check after ensuring that your logs are properly captured and delivered.
Description
Added a new atributte
log_drivertoContainerDefinitionmodel in theecs_service.Added checkecs_task_definition_containers_log_enabledwith respective unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.