fix(tests): patch head_bucket
function correctly
#5246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Tests for the check
cloudfront_distributions_s3_origin_non_existent_bucket
were failing because of mocking thehead_bucket
function incorrectly.Description
By specifically patching
s3_client._head_bucket
within the context of each test, we're ensuring that it returns the correct values.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.