Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): Adjust code to the new ARN formats in the ECS service #5259

Conversation

MarioRgzLpz
Copy link
Member

Context

While doing a check I noticed that AWS was updating some ARNs that would break our current ecs service. In order to stop that from happening we need to adjust the code to the new ARN format and making it that works with the actual ARN.

Link to the ARN updates here. Chapter: Amazon Resource Name (ARN) format

Description

Changed how we get the name of services and task definitions to avoid it to fail once the new ARN format is implemented.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarioRgzLpz MarioRgzLpz requested review from a team as code owners October 1, 2024 07:34
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (38e0242) to head (ce2b067).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5259      +/-   ##
==========================================
+ Coverage   89.07%   89.09%   +0.01%     
==========================================
  Files         993      993              
  Lines       30509    30509              
==========================================
+ Hits        27177    27182       +5     
+ Misses       3332     3327       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@sergargar sergargar merged commit 2511df1 into master Oct 2, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-4953-adjust-code-to-a-future-arn-update-in-the-ecs-service branch October 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants