Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inventory): add prowler scanner-inventory(auditor mode) #5265

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Oct 1, 2024

Description

This PR adds Prowler inventory for the AWS provider.

Using the flag --scan-inventory will create an output folder filled with all the information retrieved for the provider. You will find all the info inside /output/<provider>/<service>/<service>.json
Developed with help and idea from @Dev786

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners October 1, 2024 19:50
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

You can check the documentation for this PR here -> Prowler Documentation

@pedrooot pedrooot changed the title feat(inventory): add prowler inventory for aws feat(inventory): add prowler scanner inventory for aws Oct 1, 2024
@pedrooot pedrooot changed the title feat(inventory): add prowler scanner inventory for aws feat(inventory): add prowler scanner-inventory(auditor mode) Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

github-actions bot commented Oct 1, 2024

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot remove the quick-inventory since it'll be a breaking change for v4.

@pedrooot pedrooot added no-merge Please, DO NOT MERGE this PR. evaluating labels Oct 2, 2024
@pedrooot pedrooot marked this pull request as draft October 2, 2024 14:42
Copy link
Contributor

github-actions bot commented Oct 2, 2024

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

github-actions bot commented Oct 2, 2024

You can check the documentation for this PR here -> Prowler Documentation

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 27 lines in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (77ac5e3) to head (2cf1f22).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
prowler/providers/aws/lib/service/service.py 14.81% 23 Missing ⚠️
prowler/__main__.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5265      +/-   ##
==========================================
- Coverage   89.12%   89.01%   -0.11%     
==========================================
  Files         993     1001       +8     
  Lines       30509    30782     +273     
==========================================
+ Hits        27191    27401     +210     
- Misses       3318     3381      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation evaluating no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants