Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift): add new check redshift_cluster_non_default_username #5268

Conversation

danibarranqueroo
Copy link
Member

Context

This new check verifies that Amazon Redshift clusters do not use the default admin username "awsuser". Using a non-default username is crucial for reducing the risk of unauthorized access, as default usernames are well-known and often targeted by attackers.

Description

Added new check redshift_cluster_non_default_username with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners October 2, 2024 07:25
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (77ac5e3) to head (56345f4).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5268      +/-   ##
==========================================
- Coverage   89.12%   89.11%   -0.01%     
==========================================
  Files         993      994       +1     
  Lines       30509    30528      +19     
==========================================
+ Hits        27191    27205      +14     
- Misses       3318     3323       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@MrCloudSec MrCloudSec merged commit 469986d into master Oct 2, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4531-ensure-amazon-redshift-clusters-do-not-use-default-admin-username branch October 2, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants