-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoscaling): add new check autoscaling_group_elb_health_check_enabled
#5330
feat(autoscaling): add new check autoscaling_group_elb_health_check_enabled
#5330
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5330 +/- ##
==========================================
+ Coverage 89.34% 89.42% +0.08%
==========================================
Files 1013 1018 +5
Lines 31111 31278 +167
==========================================
+ Hits 27795 27970 +175
+ Misses 3316 3308 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check only applies to autoscaling groups that are associated to Elastic Load Balancers. If not, no findings should be created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, show in the status extended which check type has if it is not ELB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I've verify if the describe-auto-scaling-groups command output returns an empty array (i.e. []) for both "LoadBalancers" and "TargetGroups", meaning this that there are no ELB associated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
autoscaling_group_health_check_elb_enabled
autoscaling_group_elb_health_check_enabled
Context
This new check ensures that Amazon EC2 Auto Scaling groups associated with a load balancer use Elastic Load Balancing (ELB) health checks. ELB health checks help verify the health of instances based on additional tests provided by the load balancer, thereby supporting the availability and reliability of applications using EC2 Auto Scaling groups.
Description
Added new check
autoscaling_group_elb_health_check_enabled
with its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.