Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): add new check autoscaling_group_elb_health_check_enabled #5330

Conversation

danibarranqueroo
Copy link
Member

@danibarranqueroo danibarranqueroo commented Oct 8, 2024

Context

This new check ensures that Amazon EC2 Auto Scaling groups associated with a load balancer use Elastic Load Balancing (ELB) health checks. ELB health checks help verify the health of instances based on additional tests provided by the load balancer, thereby supporting the availability and reliability of applications using EC2 Auto Scaling groups.

Description

Added new check autoscaling_group_elb_health_check_enabled with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners October 8, 2024 12:21
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (2f8a3d2) to head (6cd05d5).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5330      +/-   ##
==========================================
+ Coverage   89.34%   89.42%   +0.08%     
==========================================
  Files        1013     1018       +5     
  Lines       31111    31278     +167     
==========================================
+ Hits        27795    27970     +175     
+ Misses       3316     3308       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrCloudSec MrCloudSec Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check only applies to autoscaling groups that are associated to Elastic Load Balancers. If not, no findings should be created.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, show in the status extended which check type has if it is not ELB.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've verify if the describe-auto-scaling-groups command output returns an empty array (i.e. []) for both "LoadBalancers" and "TargetGroups", meaning this that there are no ELB associated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@MrCloudSec MrCloudSec changed the title feat(autoscaling): add new check autoscaling_group_health_check_elb_enabled feat(autoscaling): add new check autoscaling_group_elb_health_check_enabled Oct 9, 2024
@MrCloudSec MrCloudSec self-requested a review October 9, 2024 18:10
@MrCloudSec MrCloudSec merged commit 4181ca5 into master Oct 9, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4446-ensure-auto-scaling-groups-associated-with-load-balancers-use-elb-health-checks branch October 9, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants