feat(autoscaling): add new check autoscaling_group_using_ec2_launch_template
#5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5346 +/- ##
==========================================
- Coverage 89.43% 89.38% -0.05%
==========================================
Files 1027 1028 +1
Lines 31531 31551 +20
==========================================
+ Hits 28200 28203 +3
- Misses 3331 3348 +17 ☔ View full report in Codecov by Sentry. |
…-groups-use-amazon-ec-2-launch-templates
MrCloudSec
requested changes
Oct 14, 2024
| @@ -0,0 +1,32 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "autoscaling_group_launch_template", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "autoscaling_group_launch_template", | |
| "CheckID": "autoscaling_group_using_ec2_launch_template", |
| report.resource_tags = group.tags | ||
| report.status = "PASS" | ||
| report.status_extended = ( | ||
| f"Autoscaling group {group.name} is using a launch template." |
There was a problem hiding this comment.
Suggested change
| f"Autoscaling group {group.name} is using a launch template." | |
| f"Autoscaling group {group.name} is using a EC2 launch template." |
| ): | ||
| report.status = "FAIL" | ||
| report.status_extended = ( | ||
| f"Autoscaling group {group.name} is not using a launch template." |
There was a problem hiding this comment.
Suggested change
| f"Autoscaling group {group.name} is not using a launch template." | |
| f"Autoscaling group {group.name} is not using a EC2 launch template." |
MrCloudSec
changed the title
autoscaling_group_launch_templateautoscaling_group_using_ec2_launch_template
…-groups-use-amazon-ec-2-launch-templates
MrCloudSec
approved these changes
Oct 14, 2024
MrCloudSec
deleted the
PRWLR-4449-ensure-amazon-ec-2-auto-scaling-groups-use-amazon-ec-2-launch-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new check ensures that Amazon EC2 Auto Scaling groups are created using Amazon EC2 launch templates. Using launch templates provides access to the latest features and improvements, compared to launch configurations, and allows for more flexible and efficient management of Auto Scaling group settings.
Additionally, an ASG can utilize a Mixed Instances Policy to combine different instance types within the same group. Within this policy, a Launch Template can also be specified. In this case, the
LaunchTemplatefield is located within theMixedInstancesPolicystructure rather than at the root of the ASG.So, if we only verify the LaunchTemplate field at the ASG level, you might overlook ASGs that use Launch Templates within a Mixed Instances Policy. Therefore, to ensure thoroughness and accuracy in your verification, it is crucial to examine both locations.
Description
Added new check
autoscaling_group_launch_templatewith its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.