Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): add g++ to Dockerfile for presidio-analyzer compatibility #5645

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

MrCloudSec
Copy link
Member

Context

The absence of g++ was causing docker build to fail due to compilation errors in dependencies like cymem and murmurhash. Adding g++ ensures successful installation of presidio-analyzer and related packages.

Description

Addsg++ to the Dockerfile to resolve build issues with presidio-analyzer, which requires a C++ compiler for certain dependencies.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners November 5, 2024 21:48
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (4efb70a) to head (be22754).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5645      +/-   ##
==========================================
- Coverage   89.86%   89.84%   -0.02%     
==========================================
  Files        1115     1115              
  Lines       34557    34557              
==========================================
- Hits        31054    31049       -5     
- Misses       3503     3508       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@MrCloudSec MrCloudSec added the backport-to-v4.5 Backport PR to the v4.5 branch label Nov 6, 2024
@MrCloudSec MrCloudSec merged commit 43efabe into master Nov 6, 2024
11 of 12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5177-fix-docker-build-action branch November 6, 2024 15:45
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Nov 6, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.5 Backport PR to the v4.5 branch was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants