Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): remove cloudwatch_log_group_no_critical_pii_in_logs check #5735

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

MrCloudSec
Copy link
Member

Description

Remove check cloudwatch_log_group_no_critical_pii_in_logs since presidio-analyzer is downloading a package during Prowler execution.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners November 12, 2024 16:01
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Nov 12, 2024
@MrCloudSec MrCloudSec force-pushed the PRWLR-5341-create-fix-release-4-5-2 branch from 61d6c8a to cbde940 Compare November 12, 2024 16:03
@MrCloudSec MrCloudSec force-pushed the PRWLR-5341-create-fix-release-4-5-2 branch from cbde940 to 1471bd5 Compare November 12, 2024 16:08
@MrCloudSec MrCloudSec changed the base branch from v4.5 to master November 12, 2024 16:08
@MrCloudSec MrCloudSec changed the base branch from master to v4.5 November 12, 2024 16:09
@MrCloudSec MrCloudSec removed provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Nov 12, 2024
jfagoagas
jfagoagas previously approved these changes Nov 12, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are removing the check cloudwatch_log_group_no_critical_pii_in_logs for the following reasons:

  • It uses the presidio-analyzer library which by default loads during runtime the NLP module and other PII recognizers from external sources not defined in the Prowler dependencies. That's something we could not do as a security product taking also into account that Prowler can run in environments with little to zero access to the Internet.
  • Those dependencies cannot be installed via poetry since they are not available in PyPI and would require adding more steps to our installation procedure to get them.
  • The NLP module installed, en-core-web-lg is a large vector table with ~500k entries with a size of 400MiB. This is a huge package to be donwloaded during runtime.
  • The installation procedure of the above dependencies adds several lines to our terminal UI with the download process and some logs.
  • presidio-analyzer requires a ton of new libraries that we need to review first.

We will work to reintroduce the cloudwatch_log_group_no_critical_pii_in_logs in a way that all dependencies are explicitly defined, required and verified.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (f8e0db4) to head (214e12c).
Report is 1 commits behind head on v4.5.

Additional details and impacted files
@@            Coverage Diff             @@
##             v4.5    #5735      +/-   ##
==========================================
- Coverage   89.89%   89.85%   -0.04%     
==========================================
  Files        1115     1114       -1     
  Lines       34560    34501      -59     
==========================================
- Hits        31067    31002      -65     
- Misses       3493     3499       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit dba914d into v4.5 Nov 12, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5341-create-fix-release-4-5-2 branch November 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants