Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very minor formatting changes #192

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

codykonior
Copy link
Contributor

Changes proposed in this pull request:

  • Some files had BOM headers, these were removed so they're raw UTF8
  • Replaced the few instances of tabs with spaces
  • In the Pester tests if $PSVersion isn't defined then we define it so users can run Invoke-Pester

Has been tested on (remove any that don't apply):

  • Powershell 5.1
  • Windows 10

@MVKozlov
Copy link
Contributor

Stripped BOM headers not supported in PSv2, It fail to detect utf8

@codykonior
Copy link
Contributor Author

If this were true then the module would not function in the first place, because not every file used a BOM header. Only some files had BOM header and this standardises them.

Second of all the module still executes when run under powershell -version 2.

@MVKozlov
Copy link
Contributor

May be this is becase it really does not contain any non-ascii symbols, so it non-utf ? :)

But contain BOM on accident, so the topic should sound like 'convert unneeded utf to ascii' ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants