Merge pull request #188 from L-Naej/develop

Fix: Handle HTTP NO CONTENT status code (204) to prevent null reference exceptions in HttpBase.cs
proyecto26 · Dec 9, 2021 · 41ee187 · 41ee187
2 parents f5430ef + c4d3841
commit 41ee187
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Proyecto26.RestClient/Helpers/HttpBase.cs b/Proyecto26.RestClient/Helpers/HttpBase.cs
@@ -8,6 +8,8 @@ namespace Proyecto26
 {
     public static class HttpBase
     {
+        public static int HTTP_NO_CONTENT = 204;
+
         public static IEnumerator CreateRequestAndRetry(RequestHelper options, Action<RequestException, ResponseHelper> callback)
         {
 
@@ -118,7 +120,7 @@ public static IEnumerator DefaultUnityWebRequest<TResponse>(RequestHelper option
                 var body = default(TResponse);
                 try
                 {
-                    if (err == null && res.Data != null && options.ParseResponseBody)
+                    if (err == null && res.StatusCode != HTTP_NO_CONTENT && res.Data != null && options.ParseResponseBody)
                         body = JsonUtility.FromJson<TResponse>(res.Text);
                 }
                 catch (Exception error)
@@ -139,7 +141,7 @@ public static IEnumerator DefaultUnityWebRequest<TResponse>(RequestHelper option
                 var body = default(TResponse[]);
                 try
                 {
-                    if (err == null && res.Data != null && options.ParseResponseBody)
+                    if (err == null && res.StatusCode != HTTP_NO_CONTENT && res.Data != null && options.ParseResponseBody)
                         body = JsonHelper.ArrayFromJson<TResponse>(res.Text);
                 }
                 catch (Exception error)