Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filament Change (german version) shows [J ][MEH] statt [Ja][nein] #3611

Closed
MagWolfgangPraxl opened this issue Dec 18, 2023 · 11 comments
Closed
Assignees
Labels
bug Something isn't working.

Comments

@MagWolfgangPraxl
Copy link

Please, before you create a new bug report, please make sure you searched in open and closed issues and couldn't find anything that matches.

Prusa MINI+ - [MINI]

5.1.2 - [e.g. 4.0.5, ...]

Original - [Original/Custom]

** Filament Runout Sensor** - [e.g. Filament Runout Sensor]

USB/Octoprint
Please let us know if you print via USB flash drive or USB/Octoprint

Filament Change (german version) shows [J ][MEH] statt [Ja][nein]
A clear and concise description of what the bug is.

** Go to "Filament Change (german version)" -- follow instructions**
Please describe steps to reproduce the behavior.

Is Filament clean -- [Ja][nein]
A clear and concise description of what you expected to happen.

@MagWolfgangPraxl MagWolfgangPraxl added the bug Something isn't working. label Dec 18, 2023
@bkerler
Copy link
Contributor

bkerler commented Dec 18, 2023

Can you please upload a picture ? This way it's easier to see if that's a translation issue or a bug. Update: Not needed anymore. See below.

@bkerler
Copy link
Contributor

bkerler commented Dec 18, 2023

I assume this screen:
image

@bkerler
Copy link
Contributor

bkerler commented Dec 18, 2023

That's a translation issue / Screen layout issue:
It should say "JA", "MEHR", "WIEDERHOLEN".
By shortening "WIEDERHOLEN" to "WDH.", the screen would look like this:

image

Would this be acceptable (Would be easiest to fix) ?

@MagWolfgangPraxl
Copy link
Author

MagWolfgangPraxl commented Dec 18, 2023 via email

@Th3Rom3
Copy link

Th3Rom3 commented Dec 18, 2023

That's a translation issue / Screen layout issue: It should say "JA", "MEHR", "WIEDERHOLEN". By shortening "WIEDERHOLEN" to "WDH.", the screen would look like this:

image

Would this be acceptable (Would be easiest to fix) ?

I wouldn't say that "Mehr" is the correct negative reply to the question "Farbe korrekt?". It makes sense in context but isn't technically correct. I personally would go with "Ja" "Nein" "WDH." But I guess this might break with the original software design intention.

@bkerler
Copy link
Contributor

bkerler commented Dec 18, 2023

@Th3Rom3 Yes, exactly that was my feeling about it as well. But the way this menu was designed, it is as it is.
@MagWolfgangPraxl Ok, will push a PR for it tomorrow :)

@bkerler
Copy link
Contributor

bkerler commented Dec 18, 2023

PR #3614 has been pushed :)

Copy link

github-actions bot commented Jun 6, 2024

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@danopernis danopernis self-assigned this Jun 6, 2024
@danopernis danopernis added the scheduled We are working on it or we have scheduled it for one of the next releases. label Jun 6, 2024
@danopernis
Copy link
Member

New version of the firmware 6.1.2 should contain the fix, can you test that?

@danopernis danopernis removed the scheduled We are working on it or we have scheduled it for one of the next releases. label Aug 22, 2024
@MagWolfgangPraxl
Copy link
Author

For me it works (firmware 6.1.2 mini-english-german) in both cases:

  • menu item filament change menu item and
  • color change (M600)
    Thank you !

@bkerler
Copy link
Contributor

bkerler commented Aug 24, 2024

@MagWolfgangPraxl can you then please close the issue if everything is fine by now ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

4 participants