Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BFW-5652] mmu3: skip unloading filament on early abort #4031

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[BFW-5652] mmu3: skip unloading filament on early abort #4031

merged 1 commit into from
Jun 6, 2024

Conversation

krx
Copy link
Contributor

@krx krx commented Jun 6, 2024

checks if filament is loaded before queuing M702

fixes #3955

@krx
mmu3: skip unloading filament on early abort
66240c5 
checks if filament is loaded before queuing M702

fixes prusa3d#3955
DRracer
DRracer approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@DRracer DRracer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 this basically implies, that the filament sensor and FINDA can be relied on.
Not sure if we want that in all cases (esp. when resolving error states), but when the print has been started already, both fsensor and FINDA probably did their job correctly.

@danopernis danopernis changed the title mmu3: skip unloading filament on early abort [BFW-5652] mmu3: skip unloading filament on early abort Jun 6, 2024
@danopernis danopernis merged commit 024103c into prusa3d:master Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRracer DRracer DRracer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BFW-5652] Needless Filament Unload Procedure, when MMU Print is cancelled in the Warm Up Phase
3 participants
@krx @DRracer @danopernis