Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple network flags should prevent the BN to start. #13801

Closed
nalepae opened this issue Mar 26, 2024 · 4 comments · Fixed by #14169
Closed

Multiple network flags should prevent the BN to start. #13801

nalepae opened this issue Mar 26, 2024 · 4 comments · Fixed by #14169
Assignees
Labels
Bug Something isn't working Good First Issue Good for newcomers

Comments

@nalepae
Copy link
Contributor

nalepae commented Mar 26, 2024

Describe the bug

Let's run the BN with both --sepolia and --holesky flags, like:

bazel run //cmd/beacon-chain --config=release -- --execution-endpoint=http://localhost:8551 --sepolia --jwt-secret /Users/manu/OffchainLabs/ethereum/jwt.hex --checkpoint-sync-url https://sepolia.beaconstate.info --genesis-beacon-api-url https://sepolia.beaconstate.info --accept-terms-of-use --holesky --force-clear-db

The BN starts. It should exit on error immediately.

Has this worked before in a previous version?

Probably not.

Related to: #13799

@nalepae nalepae added the Bug Something isn't working label Mar 26, 2024
@nalepae nalepae changed the title Multiple network flags should prevent the BN to start immediately. Multiple network flags should prevent the BN to start. Mar 26, 2024
@nalepae nalepae self-assigned this Mar 26, 2024
@prestonvanloon prestonvanloon added Good First Issue Good for newcomers Help Wanted Extra attention is needed labels Mar 26, 2024 — with Linear
@prestonvanloon prestonvanloon removed the Help Wanted Extra attention is needed label Mar 26, 2024
@shyam-patel-kira
Copy link
Contributor

Hey @nalepae, I'd like to contribute to this issue, unsure how can I test a particular change, let's say in cmd/beacon-chain/main.go

@nalepae
Copy link
Contributor Author

nalepae commented Jul 1, 2024

To run tests with bazel, you can look at here.

Also, it is also possible to run test without bazel, and especially to run tests directly in your code editor (ex: VSCode) as usual.

@shyam-patel-kira
Copy link
Contributor

I already looked, and I get that I can run it this way, but there are no test case for multiple network/chainId flags, should I create new tests, if yes where should I do that?

@nalepae
Copy link
Contributor Author

nalepae commented Jul 1, 2024

For the scope of this ticket, you can, for example, create a test that enable multiple flags, and check that in this case the BN refuses to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants