fix: Multiple network flags should prevent the BN to start #14169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nalepae
reviewed
Jul 3, 2024
nalepae
reviewed
Jul 3, 2024
nalepae
reviewed
Jul 3, 2024
nalepae
reviewed
Jul 3, 2024
|
I know the GH issue is only for the beacon node. Could you handle them as well? |
nalepae
reviewed
Jul 3, 2024
I added it to the validator client, can you point out which other cli needs to be changed? |
nalepae
reviewed
Jul 9, 2024
config/features/config.go
Outdated
| @@ -337,3 +339,24 @@ func logDisabled(flag cli.DocGenerationFlag) { | |||
| } | |||
| log.WithField(name, flag.GetUsage()).Warn(disabledFeatureFlag) | |||
| } | |||
|
|
|||
| // ValidateNetworkFlags validates and prevents beacon node | |||
There was a problem hiding this comment.
Updated the comment
The only other place I see these flags are: |
added it here |
|
Thanks! |
nalepae
approved these changes
Jul 10, 2024
Merged
via the queue into
prysmaticlabs:develop
with commit Jul 10, 2024
7c81c7d
16 of 17 checks passed
saolyn
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Implement Initial Logic * Include check in main.go * Add tests for multiple flags * remove usage of append * remove config/features dependency * Move ValidateNetworkFlags to config/features * Nit * removed NetworkFlags from cmd * remove usage of empty string literal * add comment * add flag validation to prysctl validator-exit --------- Co-authored-by: Manu NALEPA <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
* add http endpoint * add tests * Gaz * Add pointers * add endpoint to test * Electra: EIP-7251 Update `process_voluntary_exit` (#14176) * Electra: EIP-7251 Update `process_voluntary_exit` * Add unit test for VerifyExitAndSignature EIP-7251 * @potuz peer feedback * Avoid Cloning When Creating a New Gossip Message (#14201) * Add Current Changes * add back check * Avoid a Panic * fix: Multiple network flags should prevent the BN to start (#14169) * Implement Initial Logic * Include check in main.go * Add tests for multiple flags * remove usage of append * remove config/features dependency * Move ValidateNetworkFlags to config/features * Nit * removed NetworkFlags from cmd * remove usage of empty string literal * add comment * add flag validation to prysctl validator-exit --------- Co-authored-by: Manu NALEPA <[email protected]> * fix tests * Radek' review + tests * fix tests * Radek' review * forgot one * almost forgot the tests --------- Co-authored-by: Preston Van Loon <[email protected]> Co-authored-by: Nishant Das <[email protected]> Co-authored-by: kira <[email protected]> Co-authored-by: Manu NALEPA <[email protected]> Co-authored-by: Radosław Kapka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This will prevent BN from starting if there are multiple network flags
Which issues(s) does this PR fix?
Fixes #13801
Other notes for review
Let me know if I need to add comments to change any part of the code