-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulated Backend State Transition Tests Part 1 #1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve the thing * lint * PR feedback * lint
prestonvanloon
approved these changes
Jan 4, 2019
terencechain
approved these changes
Jan 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. No comment
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
+ Coverage 73.06% 73.15% +0.09%
==========================================
Files 86 85 -1
Lines 5825 5797 -28
==========================================
- Hits 4256 4241 -15
+ Misses 1221 1214 -7
+ Partials 348 342 -6 |
nisdas
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #904
Description
This PR serves as the first instance of using our simulated backend to run YAML tests for pure state transitions of the beacon chain. This PR creates a
StateTest
category for YAML, and advances a beacon state by N slots given the following configuration:This PR only advances the state without including any blocks during each state transition instance.
Steps to Reproduce