Fix sandwich attack on honest reorgs #12418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
May 21, 2023
terencechain
approved these changes
May 22, 2023
nisdas
reviewed
May 23, 2023
| @@ -82,6 +82,11 @@ func (f *ForkChoice) ShouldOverrideFCU() (override bool) { | |||
| if head.weight*100 > f.store.committeeWeight*params.BeaconConfig().ReorgWeightThreshold { | |||
| return | |||
| } | |||
|
|
|||
| // Only orphan a block if the parent LMD vote is strong | |||
| if parent.weight*100 < f.store.committeeWeight*params.BeaconConfig().ReorgParentWeightThreshold { | |||
james-prysm
pushed a commit
that referenced
this pull request
May 23, 2023
* Fix sandwich attack on honest reorgs * fix test --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ethereum/consensus-specs#3034 (comment)
And https://ethresear.ch/t/selfish-mining-in-pos/15551/3
The value of 160 may be discussed.