g/wei math->primitives, some new helpers #14026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
wei-tidier
branch
2 times, most recently
from
cf8d48b
to
405c46d
Compare
terencechain
previously approved these changes
May 20, 2024
rauljordan
approved these changes
May 20, 2024
terencechain
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other - cleanup
What does this PR do? Why is it needed?
blocks.PayloadValueToWei->primitives.BigEndianBytesToWei. This is a general purpose helper which I think was defined in the consensus-types blocks package due to import issues. This change groups it with other g/wei operations and names it to describe the general purpose thing it does.Other notes for review
This is part of the process of breaking up #13962 into smaller PRs